Messages in this thread | | | Date | Fri, 13 Jul 2007 07:48:06 +0200 | From | Cornelia Huck <> | Subject | Re: [PATCH] try parent numa_node at first before using default |
| |
On Thu, 12 Jul 2007 10:59:53 -0700, Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
> @@ -1285,8 +1290,11 @@ int device_move(struct device *dev, struct device *new_parent) > dev->parent = new_parent; > if (old_parent) > klist_remove(&dev->knode_parent); > - if (new_parent) > + if (new_parent) { > klist_add_tail(&dev->knode_parent, &new_parent->klist_children); > + set_dev_node(dev, dev_to_node(new_parent)); > + } > + > if (!dev->class) > goto out_put; > error = device_move_class_links(dev, old_parent, new_parent);
You're not correctly undoing the changes if the last function fails. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |