Messages in this thread | | | Date | Fri, 13 Jul 2007 03:07:10 +0100 | From | Al Viro <> | Subject | Re: [PATCH] Simplify /proc/<pid|self>/exe symlink code |
| |
On Thu, Jul 12, 2007 at 07:00:12PM -0700, Matt Helsley wrote: > This patch avoids holding the mmap semaphore while walking VMAs in response to > programs which read or follow the /proc/<pid|self>/exe symlink. This also allows > us to merge mmu and nommu proc_exe_link() functions. The costs are holding the > task lock, a separate reference to the executable file stored in the task > struct, and increased code in fork, exec, and exit paths.
I don't think it's a food idea. Consider a program that deliberately creates an executable anon memory, copies the binary there, jumps there and unmaps the original. In the current tree you'll get nothing pinning the binary; with your patch it will remained busy.
It's not a common situation, of course, but there are legitimate uses for such technics... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |