Messages in this thread | | | Date | Fri, 8 Jun 2007 18:39:11 +0200 | From | Adrian Bunk <> | Subject | Re: [PATCH] update checkpatch.pl to version 0.03 |
| |
On Fri, Jun 08, 2007 at 04:42:36PM +0100, Alan Cox wrote: > > >>> Does the console handle it correctly during boot? > > Yes > > > >>> Can all tools that process the syslog cope with it? > > Thats a stupid question. The tools people normally use can just fine. > > > >If you find any source file that contains UTF-8 outside of comments > > >please complain loudly. > > > > I present loudly and proudly (I *don't* complain): > > Point made - Adrian, if the tool complains about UTF-8 in author texts > then its buggy and should not be merged. The fact you have a personal > issue with it is neither here nor there
It's not a personal issue. Generally, I like UTF-8.
I'm simply saying that allowing UTF-8 in MODULE_AUTHOR and printk's as you want to can have unwanted effects.
And I gave modinfo as an example for a tool that is not yet able to handle UTF-8 correctly in all cases.
In my opinion, it's not worth the hassle to allow UTF-8 there. Feel free to disagree.
> > So, we had some ISO8859-1 and some UTF-8 in there already. (And as for > > MODULE_AUTHOR, it should stay there - 'fix' modinfo instead.) > > Using UTF-8 not 8859-1 for consistency is sensible, especially as 8859-1 > is obsolete and effectively useless now (although I guess much of the > '8859-1' in the kernel is 1:1 with 8859-15, which isn't so obsolete but > is just as useless)
Agreed, if we allow a non-ASCII charset, it should be UTF-8.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |