Messages in this thread | | | Date | Thu, 7 Jun 2007 14:23:54 +0530 | From | "Nitin Gupta" <> | Subject | Re: [PATCH -mm] Add LZO1X compression support to the kernel |
| |
On 6/7/07, Richard Purdie <rpurdie@openedhand.com> wrote: > On Thu, 2007-06-07 at 10:11 +0530, Nitin Gupta wrote: > > Your code now looks nice and clean. But I don't know what you want. I > > already spent lot of time on version 7 I posted and contains all those > > corrections which were suggested for my earlier version. I cannot ask > > you to look into possible problems (if any) in my code now since you > > are not interested in that anyway. So, please continue this > > duplication. > > What I (and others) repeatedly asked for was an explanation of why there > were the differences between the bytecode from your version and the > bytecode from mine. This was never explained by you and I was left to do > this myself. Sadly, doing so meant some duplication. >
I don't know the reason for bytecode difference. I focused on making sure that the C code is functionally identical to original code. I never did a bytecode diff.
> Anyhow, I think I can now explain the differences. Now we have two > versions, its a question of how to proceed. Basically one needs to be > merged into the other. I will try and compare the two patches and see > what differences we have.
Sounds good.
Regards, Nitin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |