Messages in this thread Patch in this message | | | Date | Thu, 7 Jun 2007 15:10:12 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH 9/36] drivers edac new intel 5000X mc driver |
| |
On Thu, 7 Jun 2007 14:38:40 -0700 Andrew Morton wrote:
> On Sun, 3 Jun 2007 07:40:26 -0700 (PDT) > Doug Thompson <norsk5@yahoo.com> wrote: > > > +static void i5000_process_nonfatal_error_info(struct mem_ctl_info > > *mci, > > + struct i5000_error_info * info, > > ditto (please check whole patch) > > (I thought checkpatch.pl would catch this, but it doesn't?)
Here's a small patch against v.3 that will catch this.
--- From: Randy Dunlap <randy.dunlap@oracle.com>
Catch "struct * blah" by allowing spaces preceding the '*'. Bah. Maybe the error string needs a small change also.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- scripts.orig/checkpatch-v3.pl +++ scripts/checkpatch-v3.pl @@ -393,7 +393,7 @@ sub process { } # * goes on variable not on type - if ($line=~/[A-Za-z\d_]+\* [A-Za-z\d_]+/) { + if ($line=~/[\sA-Za-z\d_]+\* [A-Za-z\d_]+/) { print "\"foo* bar\" should be \"foo *bar\"\n"; print "$herecurr"; $clean = 0; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |