Messages in this thread | | | Date | Wed, 6 Jun 2007 17:44:07 +0900 | From | Paul Mundt <> | Subject | Re: [PATCH 4/4] mm: variable length argument support |
| |
On Wed, Jun 06, 2007 at 01:36:58AM -0700, Andrew Morton wrote: > On Tue, 05 Jun 2007 17:05:27 +0200 Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > > > From: Ollie Wild <aaw@google.com> > > > > Remove the arg+env limit of MAX_ARG_PAGES by copying the strings directly > > from the old mm into the new mm. > > > > We create the new mm before the binfmt code runs, and place the new stack > > at the very top of the address space. Once the binfmt code runs and figures > > out where the stack should be, we move it downwards. > > > > It is a bit peculiar in that we have one task with two mm's, one of which is > > inactive. > > > > ... > > > > + flush_cache_page(bprm->vma, kpos, > > + page_to_pfn(kmapped_page)); > > Breaks SuperH: > > fs/exec.c: In function `bprm_mm_init': > fs/exec.c:268: warning: unused variable `vma' > fs/exec.c: In function `copy_strings': > fs/exec.c:431: error: structure has no member named `vma' > More pointedly, bprm->vma doesn't exist if CONFIG_MMU=n, which Andrew's config seems to have ;-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |