Messages in this thread | | | Date | Wed, 6 Jun 2007 16:03:10 +0100 | From | Alan Cox <> | Subject | Re: [SERIAL] Don't optimise away baud rate changes when BOTHER is used |
| |
On Wed, 06 Jun 2007 13:30:10 +0100 David Woodhouse <dwmw2@infradead.org> wrote:
> The uart_set_termios() function will bail out early without bothering to > touch the hardware, if it decides that nothing "relevant" has changed. > Unfortunately, its idea of "relevant" doesn't include c_[io]speed. So if > the baud rate bits are BOTHER and you just change the speed, the change > gets optimised away. > > This patch makes it ignore the old Bfoo bits in c_cflag and just check > whether c_ispeed and c_ospeed have changed. Those integers are always > set appropriately for us by set_termios().
Yep - and there are some other changes needed as well once everyone gets their ports properly lined up (notably handing back the actual speed).
Acked-by: Alan Cox <alan@redhat.com> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |