Messages in this thread | | | Date | Tue, 5 Jun 2007 17:11:44 -0700 (PDT) | From | Davide Libenzi <> | Subject | Re: [PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes |
| |
On Wed, 6 Jun 2007, Benjamin Herrenschmidt wrote:
> On Tue, 2007-06-05 at 15:50 -0700, Davide Libenzi wrote: > > > What about the code in __dequeue_signal though ? That notifier thing > > is > > > used by the DRI though I'm not sure what would happen if it acts on > > the > > > wrong task. > > > > Hmm, looking at the comments in block_all_signals(), it seems that > > they're > > interested in the fact that a specific task dequeue the signal. So, > > at > > a first sight, it seems that such code should not not be executed if > > another task dequeue the message. What do you think? > > Yes, I think the idea is that the DRM uses that to prevent signals to be > delivered to the task that is blocking them with the notifier (I have no > idea why they can't use the normal block mecanism for that... looks like > a hack to me). > > So I suppose it's fine, as long as you add a test of tsk == current to > avoid calling it.
Are you going patchwise, or should I do it?
- Davide
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |