Messages in this thread | | | Date | Tue, 5 Jun 2007 22:28:50 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH] UDF: coding style conversion - lindent fixups 2 |
| |
[Joe Perches - Tue, Jun 05, 2007 at 11:20:46AM -0700] | On Tue, 2007-06-05 at 22:03 +0400, Cyrill Gorcunov wrote: | > - cpu_to_le32(epos.offset - | > - sizeof(struct allocExtDesc)); | > - if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT) | > - || UDF_SB_UDFREV(inode->i_sb) >= 0x0201) | > + cpu_to_le32(epos.offset - | > + sizeof(struct allocExtDesc)); | > + if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT) || | > + UDF_SB_UDFREV(inode->i_sb) >= 0x0201) | | Please do not move logical operators or tests from | "beginning of next line" to "end of line". | | It's coder taste and there is no style guide consensus for this. | | cheers, | | Joe |
Actually a such conversion were made by Lindent - not coder... See for original truncate.c in current Linus's tree
Cyrill
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |