Messages in this thread | | | Date | Mon, 4 Jun 2007 10:05:35 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] sendfile removal |
| |
On Mon, Jun 04 2007, Fengguang Wu wrote: > Hi Jens, > > This is another try, still not in a comfortable state though. > //Busy waiting is possible for interleaved reads.
A few random comments...
Adding an internal flag is fine, but please put it at the upper end of the spectrum. So, use (1 << 31) for that flag.
And please work on the #splice branch of the block repo, not -mm. There are quite a few things pending for inclusion in there, and I'm sure your patch as-is wont apply.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |