lkml.org 
[lkml]   [2007]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git patches] libata fixes
Andrew Morton wrote:
> On Wed, 27 Jun 2007 03:35:26 -0400 Jeff Garzik <jeff@garzik.org> wrote:
>
>> + /* Don't allow DMA if it isn't multiple of 16 bytes. Quite a
>> + * few ATAPI devices choke on such DMA requests.
>> + */
>> + if (unlikely(qc->nbytes & 15))
>> + return 1;
>
> It might be worth emitting a diagnostic when this happens.

I tend to disagree, but if any screaming users show up, we can certainly
think about adding some.

Such would be a diagnostic that would trigger on valid SCSI commands,
when the user is doing nothing wrong and the system can indeed complete
the command just fine. Additionally, this is moving us in the direction
of what the IDE driver has apparently been doing.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-27 09:49    [W:0.051 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site