Messages in this thread | | | Date | Wed, 27 Jun 2007 12:08:15 +0530 | From | Bharata B Rao <> | Subject | Re: [PATCH] Fix for bad lock balance in Containers |
| |
On Tue, Jun 26, 2007 at 10:30:11AM +0530, Dhaval Giani wrote: > > --- linux-2.6.22-rc4/kernel/container.c 2007-06-13 15:38:32.000000000 +0530 > +++ old/kernel/container.c 2007-06-25 00:55:03.000000000 +0530 > @@ -995,6 +995,7 @@ static int container_get_sb(struct file_ > BUG_ON(ret); > } else { > /* Reuse the existing superblock */ > + down_write(&(root->sb->umount)); > ret = simple_set_mnt(mnt, root->sb); > if (!ret) > atomic_inc(&root->sb->s_active);
Do you want to change this to first take refererence on sb and then do simple_set_mnt() ?
And btw, simple_set_mnt() always returns zero and looks like it can't fail.
Regards, Bharata. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |