Messages in this thread | | | Date | Wed, 27 Jun 2007 16:32:58 -0400 | From | Muli Ben-Yehuda <> | Subject | Re: [PATCH] x86_64: change _map_single to static in pci_gart.c etc |
| |
On Wed, Jun 27, 2007 at 01:29:46PM -0700, Yinghai Lu wrote: > On 6/27/07, Andi Kleen <ak@suse.de> wrote: > >On Wednesday 27 June 2007 22:25:11 Yinghai Lu wrote: > >> On 6/27/07, Andi Kleen <ak@suse.de> wrote: > >> > On Wednesday 27 June 2007 19:41:21 Yinghai Lu wrote: > >> > > [PATCH] x86_64: change _map_single to static in pci_gart.c etc > >> > > > >> > > there function is called via dma_ops->.., so change it to static > >> > > >> > Actually all these functions shouldn't be inline in the first place. > >> > >> do you mean pci_map_single==>dma_map_single==>gart_map_single? > > > >dma_map_single. pci_map_single is ok because it doesn't really > >change anything. > > move dma_map_single from include/asm-x86_64/dma_mapping.h to > arch/x86_64/pci-dma.c?
If yes, why? it's not exactly a big function:
static inline dma_addr_t dma_map_single(struct device *hwdev, void *ptr, size_t size, int direction) { BUG_ON(!valid_dma_direction(direction)); return dma_ops->map_single(hwdev, ptr, size, direction); }
I'd rather we not make it out-of-line without a compelling (numerical) reason.
Cheers, Muli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |