Messages in this thread | | | Subject | Re: [PATCH] LinuxPPS (with new syscalls API) | From | David Woodhouse <> | Date | Wed, 27 Jun 2007 18:49:48 +0100 |
| |
On Wed, 2007-06-27 at 19:45 +0200, Rodolfo Giometti wrote: > Ok. Please see the attached patch.
Looks better. All I can find to complain about is the fact that you return whatever copy_from_user() returns. Don't -- that's the number of bytes left to copy. It should be if (copy_from_user(..)) return -EFAULT;
-- dwmw2
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |