lkml.org 
[lkml]   [2007]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 16/16] fix handling of integer constant expressions


    On Wed, 27 Jun 2007, Al Viro wrote:
    >
    > Eh... I'd say that my variant for offsetof() is simply better - it usually
    > directly turns into EXPR_VALUE, right in place, without rather convoluted
    > work. Aside of "should such cast be a constant integer expression"...

    Umm. But sparse is meant to parse C code. Which very much includes *other*
    projects.

    The kernel, for example, has its own offsetof. And yes, these days we use
    "__compiler_offsetof()", but we used to do

    #define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER)

    and I seriously doubt that the kernel is the only one doing things like
    that.

    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-27 19:49    [W:3.119 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site