lkml.org 
[lkml]   [2007]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/7][TAKE5] fallocate() on s390(x)
    > Index: linux-2.6.22-rc4/arch/s390/kernel/syscalls.S
    > ===================================================================
    > --- linux-2.6.22-rc4.orig/arch/s390/kernel/syscalls.S 2007-06-11 16:16:01.000000000 -0700
    > +++ linux-2.6.22-rc4/arch/s390/kernel/syscalls.S 2007-06-11 16:27:29.000000000 -0700
    > @@ -322,6 +322,7 @@
    > SYSCALL(sys_getcpu,sys_getcpu,sys_getcpu_wrapper)
    > SYSCALL(sys_epoll_pwait,sys_epoll_pwait,compat_sys_epoll_pwait_wrapper)
    > SYSCALL(sys_utimes,sys_utimes,compat_sys_utimes_wrapper)
    > +SYSCALL(s390_fallocate,sys_fallocate,sys_fallocate_wrapper)
    > NI_SYSCALL /* 314 sys_fallocate */

    You need to remove the NI_SYSCALL line. Otherwise all following entries
    will be wrong.

    > SYSCALL(sys_utimensat,sys_utimensat,compat_sys_utimensat_wrapper) /* 315 */
    > SYSCALL(sys_signalfd,sys_signalfd,compat_sys_signalfd_wrapper)
    > Index: linux-2.6.22-rc4/include/asm-s390/unistd.h
    > ===================================================================
    > --- linux-2.6.22-rc4.orig/include/asm-s390/unistd.h 2007-06-11 16:16:01.000000000 -0700
    > +++ linux-2.6.22-rc4/include/asm-s390/unistd.h 2007-06-11 16:27:29.000000000 -0700
    > @@ -256,7 +256,8 @@
    > #define __NR_signalfd 316
    > #define __NR_timerfd 317
    > #define __NR_eventfd 318
    > -#define NR_syscalls 319
    > +#define __NR_fallocate 319
    > +#define NR_syscalls 320

    Erm... no. You use slot 314 in the syscall table but assign number 319.
    That won't work. Please use 314 for both.
    I assume this got broken when updating to newer kernel versions.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-26 17:17    [W:4.839 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site