Messages in this thread | | | Date | Tue, 26 Jun 2007 18:05:53 +0400 | From | Kirill Korotaev <> | Subject | Re: [patch -rss] Make RSS accounting display more user friendly |
| |
Balbir Singh wrote: > Kirill Korotaev wrote: > >>Paul Menage wrote: >> >>>On 6/22/07, Balbir Singh <balbir@linux.vnet.ibm.com> wrote: >>> >>> >>>>The problem with input in bytes is that the user will have to ensure >>>>that the input is >>>>a multiple of page size, which implies that she would need to use the >>>>calculator every time. >>>> >>> >>>Having input in bytes seems pretty natural to me. Why not just have >>>the RSS controller round the input to the nearest page (or whatever >>>granularity of memory the controller is able to limit at)? >> >>totally agree with Paul. >> >>Kirill >> > > Kirill > > If someone assigns a rss_limit of 1 byte and sees a usage of 1 page, > won't that be confusing. But having said that it's not a big > change, it should be easy to accommodate.
Well, from my expirience pages are hardly understandable by people. So bytes are always better and more convinient for non-programmers. Rounding is not that big issue, since people still get the result they expect (unlike to the case when they mess up with the page size).
Thanks, Kirill
P.S. 1 byte limit is not that common :)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |