Messages in this thread | | | Date | Mon, 25 Jun 2007 23:55:27 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH -mm] PM: Prevent frozen user mode helpers from failing the freezing of tasks (rev. 2) |
| |
Hi!
> [I hope the ACKs still apply.]
Uhuh, not 100% sure.
> +static int usermodehelper_disabled; > +
...
> case PM_HIBERNATION_PREPARE: > case PM_SUSPEND_PREPARE: > usermodehelper_disabled = 1; > - return NOTIFY_OK; > + smp_mb();
usermodehelper_disabled should be atomic variable, too, so we don't have to play these ugly tricks by hand? This should not be performance-critical, right? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |