Messages in this thread | | | Subject | Re: Fix signalfd interaction with thread-private signals | From | Benjamin Herrenschmidt <> | Date | Sat, 23 Jun 2007 09:16:30 +1000 |
| |
On Fri, 2007-06-22 at 15:47 -0700, Linus Torvalds wrote: > Quite frankly, it strikes me that if we want to do this, then we shouldn't > save the _process_ information at all, we should save the "sighand" > instead. > > So either we save the process info, or we save the sighand, but saving the > "group_leader" seems totally bogus. Especially as the group leader can > change (by execve()). > > One thing that strikes me as I look at that function is that the whole > signalfd thing doesn't seem to do any reference counting. Ie it looks > totally buggy wrt passing the resulting fd off to somebody else, and then > exiting in the original process. > > What did I miss?
Probably nothing... doesn't look good. What are the lifetime rules of a struct sighand tho ?
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |