Messages in this thread Patch in this message | | | Date | Thu, 21 Jun 2007 13:17:10 +0200 | From | Carsten Otte <> | Subject | Re: [BUG?]Set XIP mount option on ext2 bypass check. |
| |
Yan Zheng wrote: > I mount an ext2 fs , then remount it with xip option set. > I get message below when do write operation in the fs. Ouch. Like on mount, we should refuse -o xip on remount. The patch below fixes this issue.
Signed-off-by: Carsten Otte <cotte@de.ibm.com> --- Index: linux-2.6.22-rc4-mm/fs/ext2/super.c =================================================================== --- linux-2.6.22-rc4-mm.orig/fs/ext2/super.c +++ linux-2.6.22-rc4-mm/fs/ext2/super.c @@ -1071,6 +1071,9 @@ static int ext2_remount (struct super_bl sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | ((sbi->s_mount_opt & EXT2_MOUNT_POSIX_ACL) ? MS_POSIXACL : 0);
+ ext2_xip_verify_sb(sb); /* see if bdev supports xip, unset + EXT2_MOUNT_XIP if not */ + es = sbi->s_es; if (((sbi->s_mount_opt & EXT2_MOUNT_XIP) != (old_mount_opt & EXT2_MOUNT_XIP)) && - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |