Messages in this thread | | | Date | Thu, 21 Jun 2007 21:16:03 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 19/19] ide: use PIO/MMIO operations directly where possible |
| |
Hello.
Bartlomiej Zolnierkiewicz wrote: > [PATCH] ide: use PIO/MMIO operations directly where possible
> This results in smaller/faster/simpler code and allows future optimizations. > Also remove no longer needed ide[_mm]_{inl,outl}() and ide_hwif_t.{INL,OUTL}.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Index: a/drivers/ide/pci/hpt366.c > =================================================================== > --- a.orig/drivers/ide/pci/hpt366.c > +++ a/drivers/ide/pci/hpt366.c > @@ -836,7 +836,7 @@ static int hpt374_ide_dma_test_irq(ide_d > return 0; > } > > - dma_stat = hwif->INB(hwif->dma_status); > + dma_stat = inb(hwif->dma_status); > /* return 1 if INTR asserted */ > if (dma_stat & 4) > return 1;
Hmm... this driver *still* has a lot more indirect I/O accessors -- I wonder why only this one had been converted then?
MBR, Sergei
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |