Messages in this thread Patch in this message | | | From | NeilBrown <> | Date | Thu, 21 Jun 2007 14:30:39 +1000 | Subject | [PATCH 002 of 8] knfsd: nfsd4: fix NFSv4 filehandle size units confusion |
| |
From: "J. Bruce Fields" <bfields@fieldses.org>
NFS4_FHSIZE is measured in bytes, not 4-byte words, so much more space than necessary is being allocated for struct nfs4_cb_recall.
I should have wondered why this structure was so much larger than it needed to be!
Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu> Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output ./include/linux/nfsd/state.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff .prev/include/linux/nfsd/state.h ./include/linux/nfsd/state.h --- .prev/include/linux/nfsd/state.h 2007-06-21 13:46:39.000000000 +1000 +++ ./include/linux/nfsd/state.h 2007-06-21 14:09:31.000000000 +1000 @@ -67,7 +67,7 @@ struct nfs4_cb_recall { int cbr_trunc; stateid_t cbr_stateid; u32 cbr_fhlen; - u32 cbr_fhval[NFS4_FHSIZE]; + char cbr_fhval[NFS4_FHSIZE]; struct nfs4_delegation *cbr_dp; }; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |