lkml.org 
[lkml]   [2007]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] use __asm__ and __volatile__ in asm-x86_64/msr.h
Andi Kleen wrote:
>> asm-i386/msr.h should not be exported to userspace at all, it contains
>> nothing but kernel-internal helpers.
>
> Actually rdtsc and rdtscll and potentially rdpmc which is in there can be very
> useful in user space if you know what you're doing. Unfortunately a lot of its users don't,
> but not having the include probably won't stop them either.

More likely, people will just re-implement them incorrectly.

However, the rdtsc() definition in the kernel is weird (and removable, I
think there are no more users -- I have it removed in my MSR driver
rewrite tree which I need to get off my arse and push.) Most users
would expect the rdtscll() functionality with the rdtsc() name.

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-20 17:57    [W:0.144 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site