Messages in this thread | | | Date | Wed, 20 Jun 2007 11:37:32 -0400 | From | Jeff Dike <> | Subject | Re: [PATCH 2/2] UML - Add stack usage monitoring |
| |
On Tue, Jun 19, 2007 at 12:57:07PM -0700, Randy Dunlap wrote: > Kconfig help text is indented 2 more spaces (by convention or > CodingStyle).
OK, will fix.
> > + if(*p != 0) > > if (*p != NULL)
p is int *, so that's a int version pointer comparision.
> or > if (*p)
Conceptually, p is an int, not a boolean, so I prefer to type the extra characters to do the int-to-boolean conversion in places that want booleans.
> > + if (left < lowest_to_date) { > > + printk("Greatest stack depth - %d bytes left\n", left); > > Does UML need/use KERN_* facility levels in printk() calls?
Yes, will fix.
Jeff
-- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |