Messages in this thread | | | From | Segher Boessenkool <> | Subject | Re: [PATCH] remove usage of memmem from scripts/kallsyms.c | Date | Wed, 20 Jun 2007 17:25:37 +0200 |
| |
>>> So we could remove the "#define _GNU_SOURCE" at the top >>> of scripts/kallsyms.c too, presumably? If not (i.e. if there are >>> more GNUisms left in that file anyway), then I'm not sure if we >>> really gain by the change. >> yes, i believe this is true > > I only tried in on x86 with my toolchain and it works, but I don't > know if it is worth the risk of breaking someone's setup for virtually > no gain...
With the memmem() removed, the code builds (and works) fine on several non-GNU systems. It should be perfectly safe to remove the _GNU_SOURCE. Perhaps you should replace it with the proper POSIX_ define so it won't be broken again?
Segher
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |