Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [patches] [PATCH for 2.6.22] [10/10] x86_64: fix link warningbetween for .text and .init.text | Date | Wed, 20 Jun 2007 14:30:00 +0200 |
| |
On Wednesday 20 June 2007 14:02:49 Jan Beulich wrote: > This is the right way I think. With mtrr_bp_init being __init, get_mtrr_state > can then also be __init, making the other two changes unnecessary. I had > submitted a patch to that effect about a week ago. Beyond that patch, as > I now looked at this again, it would seem to me that print_fixed can then in > fact also be __init (rather than being __cpuinit).
Possible. I'm inclined to just leave it as it is now, don't really care about some more or less bytes in the init section.
This whole new __init checking is a constant annoyance; nearly all of these warnings are false positives and it is actually CONFIG dependent.
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |