Messages in this thread | | | Date | Wed, 20 Jun 2007 00:14:41 +0300 | From | "Pekka Enberg" <> | Subject | Re: [PATCH -mm] add a kmem_cache for nsproxy objects |
| |
Hi Christoph x 2,
On Tue, 19 Jun 2007, Christoph Hellwig wrote: > > Hmm, I must have missed the macro going in. Frankly speaking I plain hate > > it. It's a rather useless obsfucation.
I hate the name, but the macro is far from useless.
On 6/19/07, Christoph Lameter <clameter@sgi.com> wrote: > It makes the code easier to review and reduces errors by establishing a > standard way of defining a slab with minimal effort. You can > still do the old style and create the kmem_cache_create parameter > monsters that span lots of lines. > > KMEM_CACHE can do it just by specifying two parameters.
Yes and if you look at existing callers of kmem_cache_create(), you'll notice that most of them work _exactly_ the way the macro does. Most of the time you want to use default alignment and not define a constructor. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |