| Date | Mon, 18 Jun 2007 14:55:27 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: [patch 05/26] Slab allocators: Cleanup zeroing allocations |
| |
On Mon, 18 Jun 2007, Pekka Enberg wrote:
> On 6/18/07, clameter@sgi.com <clameter@sgi.com> wrote: > > +static inline void *kmem_cache_zalloc(struct kmem_cache *k, gfp_t flags) > > +{ > > + return kmem_cache_alloc(k, flags | __GFP_ZERO); > > +} > > + > > +static inline void *__kzalloc(int size, gfp_t flags) > > +{ > > + return kmalloc(size, flags | __GFP_ZERO); > > +} > > Hmm, did you check kernel text size before and after this change? > Setting the __GFP_ZERO flag at every kzalloc call-site seems like a > bad idea.
I did not check but the flags are usually constant. Compiler does the |.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|