Messages in this thread | | | Date | Mon, 18 Jun 2007 09:51:59 -0700 | From | "Nish Aravamudan" <> | Subject | Re: [PATCH] madvise_need_mmap_write() usage |
| |
On 6/18/07, Jason Baron <jbaron@redhat.com> wrote: > > On Sat, 16 Jun 2007, Christoph Hellwig wrote: > > > On Fri, Jun 15, 2007 at 11:20:31AM -0400, Jason Baron wrote: > > > hi, > > > > > > i was just looking at the new madvise_need_mmap_write() call...can we > > > avoid an extra case statement and function call as follows? > > > > Sounds like a good idea, but please move the assignment out of the > > conditional. > > > > ok, here's an updated version:
You should always append the full patch, both the diff and the rationale, I think. Even though it's quoted above, might make less work for Andrew to pull in.
Thanks, Nish - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |