Messages in this thread | | | Date | Sun, 17 Jun 2007 14:45:55 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/6] make pci_ids lowercase hexa |
| |
On Sun, Jun 17, 2007 at 09:08:31AM +0200, Jiri Slaby wrote: > Greg KH napsal(a): > > On Sat, Jun 16, 2007 at 05:44:52PM +0200, Jiri Slaby wrote: > >> make pci_ids lowercase hexa > > > > Why? What good is this going to do in the long run? > > It's just cleanup to get rid of things like this: > #define PCI_DEVICE_ID_PROMISE_20246 0x4d33 > #define PCI_DEVICE_ID_PROMISE_20262 0x4d38 > -#define PCI_DEVICE_ID_PROMISE_20263 0x0D38 > +#define PCI_DEVICE_ID_PROMISE_20263 0x0d38 > #define PCI_DEVICE_ID_PROMISE_20268 0x4d68
Get rid of what? What's wrong with upper case hex numbers? This seems like a pretty gratitous change to me.
> But still not necessary, if you think, it's useless -- but why don't > have whole document formatted in one way. However this patch needs a > -fix if ACKed due to bad regexp used (omitted '*' changes only the > first uppercase letter found). If NACKed, this doesn't matter. > > > Also, shouldn't you send pci specific patches like this to the pci > > maintainer? :) > > Hell yes :/, every second time I post something, somebody is missing > in the CC list, grr.
Care to resend your other fixes to me, if you still think they are needed?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |