Messages in this thread | | | Date | Sun, 17 Jun 2007 23:49:40 +0200 | From | Pavel Machek <> | Subject | Re: [Suspend-devel] [PATCH, 3rd try] make disable_console_suspend runtime configurable |
| |
Hi!
> > > I hate having to recompile the kernel, just to be able to debug suspend. > > > Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in > > > /sys/power/disable_console_suspend. > > > > > > > > > Signed-off-by: Stefan Seyfried <seife@suse.de> > > > Signed-off-by: Frank Seidel <fseidel@suse.de> > > > --- > > > Third try, renamed sysfs interface to console_suspend > > > reporting and expecting either "enabled" or "disabled" > > > > Thanks a lot for redoing it. > > > > I have no objections. Pavel? > > I still think that patch is bad. I should have screamed when > CONFIG_DISABLE_CONSOLE_SUSPEND went into kernel. That beast should > _not_ be configurable, it should just do the right thing. > > But I realized that too late. And this only makes it works, making > that mistake part of user-kernel interface. > > Sorry for not screaming when CONFIG_DISABLE_CONSOLE_SUSPEND went in, > but please lets solve this correctly....
Ouch and sorry for not screaming at "try 1" time. But it still does not make the patch right, and I believe that even patch authors agree that "no-config-needed" is superior solution. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |