Messages in this thread | | | Date | Sat, 16 Jun 2007 16:22:19 +0200 | From | Clifford Wolf <> | Subject | Re: coding style |
| |
Hey,
On Fri, Jun 15, 2007 at 11:16:08AM +0200, Jan Engelhardt wrote: > >> so which one is preferred for the kernel? > > err = very_long_function_name(lots_of_arguments, > less, > less, > less, > less, > even_more_arguments, > more_of_this, > more_of_that, > more, > more, > more); > > IMO, preferred: > > err = very_long_function_name(lots_of_arguments, less, less, less, less, > even_more_arguments, more_of_this, more_of_that, more, more, more);
Looking at e.g. the fuction declarations in fs/namespace.c shows very well that there seams to be no 'preferred in the kernel source' for this question.
I presonally prefer indenting the continuation of a line with TWO additional tabs so it is good to distinguish from a normally indented command block. E.g.:
static int function_with_long_name(int and_many_arguments, int not_fitting_in_a_signle_line_anymore) { if (and_many_arguments > not_fitting_in_a_signle_line_anymore && not_fitting_in_a_signle_line_anymore > 0) and_many_arguments += not_fitting_in_a_signle_line_anymore; else not_fitting_in_a_signle_line_anymore *= not_fitting_in_a_signle_line_anymore; return and_many_arguments ^ not_fitting_in_a_signle_line_anymore; }
maybe this won't win a design contest but it is a simple and non-ambiguous coding style and afaics does not conflict with the CodingStyle document.
yours, - clifford
-- When your hammer is C++, everything begins to look like a thumb. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |