Messages in this thread | | | Subject | Re: [PATCH] Introduce compat_u64 and compat_s64 types | From | Benjamin Herrenschmidt <> | Date | Fri, 15 Jun 2007 23:16:43 +1000 |
| |
On Fri, 2007-06-15 at 11:31 +0200, Arnd Bergmann wrote: > One common problem with 32 bit system call and ioctl emulation > is the different alignment rules between i386 and 64 bit machines. > A number of drivers work around this by marking the compat > structures as 'attribute((packed))', which is not the right > solution because it breaks all the non-x86 architectures that > want to use the same compat code. > > Hopefully, this patch improves the situation, it introduces two > new types, compat_u64 and compat_s64. These are defined on all > architectures to have the same size and alignment as the 32 bit > version of u64 and s64. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sounds good
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |