Messages in this thread | | | Subject | Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures | From | Vasily Tarasov <> | Date | Fri, 15 Jun 2007 14:41:49 +0400 |
| |
You can find a half-year back discussions of this patch:
First attempt: http://lkml.org/lkml/2006/10/19/123 Second attempt: http://lkml.org/lkml/2006/10/25/57
I think they will answer your questions.
Thank you, Vasily
On Fri, 2007-06-15 at 12:03 +0200, Mikael Pettersson wrote: > On Fri, 15 Jun 2007 13:01:48 +0400, Vasily Tarasov wrote: > > OpenVZ Linux kernel team has discovered the problem > > with 32bit quota tools working on 64bit architectures. > > In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() with > > the comment "sys_quotactl seems to be 32/64bit clean, enable it for 32bit" > > However this isn't right. Look at if_dqblk structure: > > Your patch only converts ia32 on x86-64 or ia64. > What about ppc32-on-ppc64 and sparc32-on-sparc64? > And, I guess, mips32-on-mips64? > > > --- linux-2.6.22-rc4-fixed/fs/quota.c.orig 2007-06-14 15:55:26.000000000 +0400 > > +++ linux-2.6.22-rc4-fixed/fs/quota.c 2007-06-14 19:50:13.000000000 +0400 > ... > > +#if defined(CONFIG_X86_64) || defined(CONFIG_IA64) > > +/* > > + * This code works only for 32 bit quota tools over 64 bit OS (x86_64, ia64) > > + * and is necessary due to alignment problems. > > + */ > > The #ifdef looks way too arch-specific. And isn't there a shared > compat.c module somewhere that this should go into? > > /Mikael
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |