Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH -mm 6/7] PM: Remove power_state.event checks from suspend core code | Date | Fri, 15 Jun 2007 00:46:12 +0200 |
| |
On Thursday, 14 June 2007 16:21, David Brownell wrote: > On Wednesday 13 June 2007, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rjw@sisk.pl> > > > > The suspend routines should be called for every device during a system sleep > > transition, regardless of the device's state, so that drivers can regard these > > method calls as notifications that the system is about to go to sleep, rather > > than as directives to put their devices into the 'off' state. > > Did you audit all the drivers to make sure this won't break things? > Like for example through inappropriate pci_save_state() calls?
I did, but not very carefully.
> I'd really expect this patch would break things...
Well, in that case I'll have a closer look at them.
Greetings, Rafael
-- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |