lkml.org 
[lkml]   [2007]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch 10/18] fs/logfs/inode.c
    On Sun, 10 June 2007 19:24:28 +0200, Arnd Bergmann wrote:
    > On Sunday 03 June 2007, Jörn Engel wrote:
    > > +struct inode *logfs_new_inode(struct inode *dir, int mode)
    > > +{
    > > +       struct super_block *sb = dir->i_sb;
    > > +       struct inode *inode;
    > > +
    > > +       inode = new_inode(sb);
    > > +       if (!inode)
    > > +               return ERR_PTR(-ENOMEM);
    > > +
    > > +       logfs_init_inode(inode);
    > > +
    > > +       inode->i_mode = mode;
    > > +       inode->i_ino = logfs_get_ino(sb);
    > > +
    > > +       insert_inode_hash(inode);
    > > +
    > > +       return inode;
    > > +}
    >
    > I think this is missing code that sets the initial i_uid/i_gid,
    > but there may be more missing. Changing the uid value works,
    > but creating files as non-root user doesn't.

    Eek! I'll have a look.

    Jörn

    --
    When in doubt, punt. When somebody actually complains, go back and fix it...
    The 90% solution is a good thing.
    -- Rob Landley
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-10 19:47    [W:6.111 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site