lkml.org 
[lkml]   [2007]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-usb-devel] [PATCH] Fix NEC OHCI chip silicon bug
On Thu, 31 May 2007, Michael Hanselmann wrote:

> This patch fixes a silicon bug in some NEC OHCI chips. The bug appears
> at random times and is very, very difficult to reproduce. Without the
> following patch, Linux would shut the chip and its associated devices
> down. In Apple PowerBooks this leads to an unusable keyboard and mouse
> (SSH still working). The idea of restarting the chip is taken from
> public Darwin code.

> @@ -779,7 +790,11 @@ static int ohci_restart (struct ohci_hcd
> */
> spin_lock_irq(&ohci->lock);
> disable (ohci);
> +
> +#ifdef CONFIG_PM
> usb_root_hub_lost_power(ohci_to_hcd(ohci)->self.root_hub);
> +#endif
> +

Suppose CONFIG_PM isn't defined. How are you going to let usbcore
know about all the old connections which no longer exist?

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-01 16:23    [W:6.180 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site