Messages in this thread | | | Subject | Re: [-mm patch] get_unmapped_area: remove now unused ret variable (was Re: 2.6.21-mm1) | From | Benjamin Herrenschmidt <> | Date | Mon, 07 May 2007 07:45:07 +1000 |
| |
On Sun, 2007-05-06 at 11:03 +0200, Frederik Deweerdt wrote: > On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm1/ > > > > mm/mmap.c:1393: warning: unused variable 'ret' > > The get_unmapped_area-doesnt-need-hugetlbfs-hacks-anymore.patch and > get_unmapped_area-handles-map_fixed-in-generic-code.patch rendered the ret > variable useless.
Ah good catch.. I wonder why my gcc didn't spot it...
> Regards, > Frederik > > Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> diff --git a/mm/mmap.c b/mm/mmap.c > index b0f6eb8..fabf7f4 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1390,7 +1390,6 @@ unsigned long > get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, > unsigned long pgoff, unsigned long flags) > { > - unsigned long ret; > unsigned long (*get_area)(struct file *, unsigned long, > unsigned long, unsigned long, unsigned long); >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |