lkml.org 
[lkml]   [2007]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [-mm patch] mutex.h bogus __must_check (was Re: 2.6.21-mm1)
    On Sat, 5 May 2007 14:14:44 +0200 Frederik Deweerdt <deweerdt@free.fr> wrote:

    > On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote:
    > >
    > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm1/
    > >
    > __must_check was added to mutex_lock_nested() which returns void. This
    > causes the following warnings:
    > include/linux/mutex.h:128: warning: 'warn_unused_result' attribute ignored
    >
    > This was introduced by
    > broken-out/mutex_lock_interruptible-add-__must_check.patch

    erp. It was supposed to be on mutex_lock_interruptible():


    --- a/include/linux/mutex.h~mutex_lock_interruptible-add-__must_check-must-fix
    +++ a/include/linux/mutex.h
    @@ -121,10 +121,10 @@ static inline int fastcall mutex_is_lock
    * Also see Documentation/mutex-design.txt.
    */
    extern void fastcall mutex_lock(struct mutex *lock);
    -extern int fastcall mutex_lock_interruptible(struct mutex *lock);
    +extern int __must_check fastcall mutex_lock_interruptible(struct mutex *lock);

    #ifdef CONFIG_DEBUG_LOCK_ALLOC
    -extern void __must_check mutex_lock_nested(struct mutex *lock,
    +extern void mutex_lock_nested(struct mutex *lock,
    unsigned int subclass);
    extern int __must_check mutex_lock_interruptible_nested(struct mutex *lock,
    unsigned int subclass);
    _
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-05 20:35    [W:4.656 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site