lkml.org 
[lkml]   [2007]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 30/40] nfs: fixup missing error code
    Commit 0b67130149b006628389ff3e8f46be9957af98aa lost the setting of tk_status
    to -EIO when there was no progress with short reads.

    Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
    ---
    fs/nfs/read.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    Index: linux-2.6-git/fs/nfs/read.c
    ===================================================================
    --- linux-2.6-git.orig/fs/nfs/read.c 2007-03-13 14:35:53.000000000 +0100
    +++ linux-2.6-git/fs/nfs/read.c 2007-03-13 14:36:05.000000000 +0100
    @@ -384,8 +384,10 @@ static int nfs_readpage_retry(struct rpc
    /* This is a short read! */
    nfs_inc_stats(data->inode, NFSIOS_SHORTREAD);
    /* Has the server at least made some progress? */
    - if (resp->count == 0)
    + if (resp->count == 0) {
    + task->tk_status = -EIO;
    return 0;
    + }

    /* Yes, so retry the read at the end of the data */
    argp->offset += resp->count;
    --

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-04 12:39    [W:6.627 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site