Messages in this thread | | | Date | Thu, 31 May 2007 18:45:17 -0700 | From | Mark Fasheh <> | Subject | Re: 2.6.22-rc3-mm1 - page_mkwrite() breakage |
| |
On Fri, Jun 01, 2007 at 03:34:02AM +0200, Nick Piggin wrote: > > Here's a nasty idea... Would it be valid for ->page_mkwrite to unlock the > > page, so long as it's returned in a locked state? Though, do we even need > > the page lock that early? It seemed to me that you were adding it for > > consistency reasons (I could be wrong though). > > You could do that, but you'd have to probably check that it is > within i_size after you relock it, I think... yeah, that might > be the best thing for ocfs to do for now.
Well, ocfs2 already does i_size checks in page_mkwrite, so we're covered with respect to truncate races.
I'm still not clear though - what was the reason for adding the page locking there in the 1st place? --Mark
-- Mark Fasheh Senior Software Developer, Oracle mark.fasheh@oracle.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |