lkml.org 
[lkml]   [2007]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Introduce O_CLOEXEC (take >2)
On Thu, 31 May 2007 16:20:21 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > diff --git a/include/asm-generic/fcntl.h b/include/asm-generic/fcntl.h
> > index c154b9d..b847741 100644
> > --- a/include/asm-generic/fcntl.h
> > +++ b/include/asm-generic/fcntl.h
> > @@ -48,6 +48,9 @@
> > #ifndef O_NOATIME
> > #define O_NOATIME 01000000
> > #endif
> > +#ifndef O_CLOEXEC
> > +#define O_CLOEXEC 02000000 /* set close_on_exec */
> > +#endif
> > #ifndef O_NDELAY
> > #define O_NDELAY O_NONBLOCK
> > #endif
>
> This will break xtensa, because that architecture (and only that
> architecture) doesn't include asm-generic/fcntl.h from asm/fcntl.h.

This also breaks Alpha (which uses 02000000 for O_DIRECT) and parisc
(which uses 02000000 for O_RSYNC). So you ether need to choose a
different value or define O_CLOEXEC for those two architectures.

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2007-06-01 03:41    [W:0.083 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site