Messages in this thread | | | Date | Thu, 31 May 2007 15:46:48 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH resend] introduce I_SYNC |
| |
On Thu, 31 May 2007 16:25:35 +0200 Jörn Engel <joern@lazybastard.org> wrote:
> On Wed, 16 May 2007 10:15:35 -0700, Andrew Morton wrote: > > > > If we're going to do this then please let's get some exhaustive commentary > > in there so that others have a chance of understanding these flags without > > having to do the amount of reverse-engineering which you've been put through. > > Done. Found and fixed some bugs in the process. By now I feal > reasonable certain that the patch fixes more than it breaks. >
> > -- > Good warriors cause others to come to them and do not go to others. > -- Sun Tzu > > Introduce I_SYNC. > > I_LOCK was used for several unrelated purposes, which caused deadlock > situations in certain filesystems as a side effect. One of the purposes > now uses the new I_SYNC bit.
Do we know what those deadlocks were? It's a bit of a mystery patch otherwise.
Put yourself in the position of random-distro-engineer wondering "should I backport this?".
> Also document the various bits and change their order from historical to > logical.
What a nice comment you added ;) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |