Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] INPUT: Sanitize PIT locking in pcspkr | Date | Fri, 18 May 2007 06:27:00 +0200 |
| |
On Thursday 17 May 2007 16:49, Thomas Gleixner wrote:
> Both read the PIT directly, which will lead to interesting results. The > PIT is either stopped or it can be used in one shot mode with per event > changing intervals due to the changes introduced by the clock events > layer. > > This code should use ktime_get() and not fiddle in the hardware itself.
The gameport code also does TSC accesses directly which is similarly broken. I remember complaining about that some time ago, but it never got fixed in the end.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |