lkml.org 
[lkml]   [2007]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Chaining sg lists for big IO commands v5
    On Fri, May 18 2007, Badari Pulavarty wrote:
    > On Fri, 2007-05-18 at 09:33 +0200, Jens Axboe wrote:
    > > On Thu, May 17 2007, Badari Pulavarty wrote:
    > > > On Thu, 2007-05-17 at 08:27 +0200, Jens Axboe wrote:
    > > > ..
    > > > > > >
    > > > > > > Ah ok, you need the updated patch series for ppc64 support. Builds fine
    > > > > > > here on ppc64. See the #sglist branch of the block repo:
    > > > > > >
    > > > > > > git://git.kernel.dk/data/git/linux-2.6-block.git
    > > > > > >
    > > > > > > I can mail you an updated patch, if you want.
    > > > > >
    > > > > >
    > > > > > Here is the whole panic stack..
    > > > >
    > > > > Thanks will fix that up, the IDE part is totally untested. Can you try
    > > > > and backout this patch and see if it boots?
    > > >
    > > > Yes. It boots fine with following backed out.
    > > >
    > > > Looking at the code ide_probe.c: hwif_init() is doing
    > > >
    > > > hwif->sg_table = kmalloc(sizeof(struct scatterlist)*hwif->sg_max_nents,
    > > > GFP_KERNEL);
    > > >
    > > > blk_rq_map_sg() is looking for the chaining info and going over end of the
    > > > allocation.
    > >
    > > Hmm, looks ok, I'm guessing it's just missing a memset (or just turn it
    > > into a kzalloc())?
    > >
    >
    > Even with backing out all the ide changes, I get this on boot
    > once in a while.

    Yep, I think the ide changes are fine as such, the problem is the
    missing memset/kzalloc. Can you try that?

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-18 19:07    [W:4.249 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site