Messages in this thread | | | Date | Thu, 17 May 2007 08:47:59 +0000 | From | Pavel Machek <> | Subject | Re: CONFIG_BREAK_MY_MACHINE |
| |
Hi!
> >>If abitguru breaks random machines, we probably should > >>DMI whitelist, > >>too. > > > >I never said it was breaking machines, just that it was > >accessing > >arbitrary I/O ports. > > > >This was already discussed with the driver's author > >(Hans de Goede, > >Cc'd) and I think we agreed on the principle, but it > >didn't happen yet. > >This device only exists on Abit motherboards so it > >would be easy enough > >to check the DMI vendor. A more detailed white list is > >also possible, > >but I'm not insisting on it. > > > >The driver could also be made to depend on X86, as this > >is the only > >architecture where it is useful. > > > >Hans, can you please submit a patch doing this? > > > > As you can see from the CC I've send you, I've just > mailed my private army of testers / known uguru users, > requesting them to send me the output of dmidecode on > their uguru mobo's. Once I have this info, I'll see if > there is some consistency in the manufacturer DMI field. > > I've mailed them, since the DMI info is needed anyways > to put uguru detection in sensors-detect, but I'm not > sure I want to add this to the driver too. Many other > ISA drivers do io probe's too, if a users decides to > start loading random drivers, he is asking for problems, > should we really even try to protect against this?
Yes. config-all-yes kernel should boot. And it should be ok to share kernel between different machines.
ISA drivers should be disappearing these days, if something does dangerous port-probe, we want to fix it somehow. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |