Messages in this thread Patch in this message | | | Date | Thu, 17 May 2007 19:52:53 +0200 | From | Tejun Heo <> | Subject | [PATCH 1/2] sysfs: fix condition check in sysfs_drop_dentry() |
| |
The condition check doesn't make much sense as it basically always succeeds. This causes NULL dereferencing on certain cases. It seems that parentheses are put in the wrong place. Fix it.
DON'T APPLY JUST YET ---
Maneesh, is this correct?
fs/sysfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: work/fs/sysfs/inode.c =================================================================== --- work.orig/fs/sysfs/inode.c +++ work/fs/sysfs/inode.c @@ -250,7 +250,7 @@ void sysfs_drop_dentry(struct sysfs_dire if (dentry) { spin_lock(&dcache_lock); spin_lock(&dentry->d_lock); - if (!(d_unhashed(dentry) && dentry->d_inode)) { + if (!d_unhashed(dentry) && dentry->d_inode) { inode = dentry->d_inode; spin_lock(&inode->i_lock); __iget(inode); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |