Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH] ubi: kill homegrown endian macros | From | Artem Bityutskiy <> | Date | Thu, 17 May 2007 17:50:43 +0300 |
| |
Christoph,
On Thu, 2007-05-17 at 16:32 +0200, Christoph Hellwig wrote: > Kill ubis homegrown endianess handling crap and replace it with > the normal kernel endianess handling.
Err,__be32 and the company are just sparse things, while I have compiler checks with my struct ubi32_t and friends. JFFS2 also uses the same technique. Why do you force me to rely on sparse instead instead of compiler?
Well, I see the good side of your change - no home-brewed media<->cpu things. Fair enough and nice. But why don't you make __be32 a struct (just like I do) so that compiler could complain then?
-- Best regards, Artem Bityutskiy (Битюцкий Артём)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |