This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Tue Jun 18 01:16:00 2024 Delivery-date: Tue, 24 Apr 2007 14:05:54 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161474AbXDXOFU (ORCPT ); Tue, 24 Apr 2007 10:05:20 -0400 Received: from mx1.redhat.com ([66.187.233.31]:54223 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161473AbXDXOFR (ORCPT ); Tue, 24 Apr 2007 10:05:17 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l3OE4iop031674; Tue, 24 Apr 2007 10:04:44 -0400 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l3OE4eTN014634; Tue, 24 Apr 2007 10:04:41 -0400 Received: from [10.32.4.77] (vpn-4-77.str.redhat.com [10.32.4.77]) by pobox.stuttgart.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l3OE4ZBr026089; Tue, 24 Apr 2007 16:04:35 +0200 Message-Id: <462E0E60.5080907@redhat.com> Date: Tue, 24 Apr 2007 16:04:16 +0200 From: Gerd Hoffmann User-Agent: Thunderbird 1.5.0.10 (X11/20070302) Mime-Version: 1.0 To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Paul Mundt , Ralf Baechle , Andi Kleen , Alan Cox , Richard Henderson , Ivan Kokshaysky , Paul Macker Subject: Re: [patch v2] Fixes and cleanups for earlyprintk aka boot console. References: <20070315154638.944768000@suse.de> <20070423234240.29427438.akpm@linux-foundation.org> In-Reply-To: <20070423234240.29427438.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org > I get this, across netconsole: >=20 > [17179569.184000] console handover: boot [earlyvga_f=11_0] -> real [t= ty0] >=20 > wanna take a look at why there's cruft in bootconsole->name please? -EFULL ;) "earlyvga" is 8 chars. struct console->name is char[8]. No space left= =20 for the trailing =B4\0=B4, the cruft comes from the next field (write=20 function pointer). Obviously nobody ever printed the early console=20 names before. Hmm. We can make the names shorter. We can make the name field longer= =20 (probably 16, it ends up taking that much anyway due to aligments at=20 least on 64bit). This looks best to me. We could also use=20 printk("%.8s",name) to make printk stop after 8 chars, but I somehow=20 don't like hardcoding the length like this ... cheers, Gerd - To unsubscribe from this list: send the line "unsubscribe linux-kernel"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/