Messages in this thread | | | Subject | Re: [rfc][patch] futex: restartable futex_wait? | From | Thomas Gleixner <> | Date | Fri, 09 Mar 2007 10:38:35 +0100 |
| |
On Fri, 2007-03-09 at 06:10 +0100, Nick Piggin wrote: > > i think that's quite right. I'm wondering why this never came up before? > > But your fix is not complete i think: > > > > > + restart->arg2 = time; > > > + return -ERESTART_RESTARTBLOCK; > > > + } > > > > 'time' here is relative, so the restarted syscall will do a /full/ wait > > again. > > But it has been modified by schedule_timeout?
But this does not change the syscall registers, so it is restarted in the same way. We need a new futex OP for this, which takes absolute time like the PI futex op does.
tglx
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |